Fix tool call with empty arguments in streaming mode #4027
+205
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huidong.yin <[email protected]>
|
See the build errors: https://github.com/spring-projects/spring-ai/actions/runs/16780012117/job/47515816009?pr=4027 Thanks. |
- Add null/empty argument handling in DefaultToolCallingManager - Add similar handling in SyncMcpToolCallback and AsyncMcpToolCallback - Add comprehensive test coverage for the fix - Apply Spring Java format to fix code style violations Signed-off-by: huidong.yin <[email protected]>
huidongyin
force-pushed
the
fix/stream-tool-call-empty-arguments
branch
from
051e430 to
91aadd3
Compare
got it ,thanks . |
Signed-off-by: huidong.yin <[email protected]>
first time commit code to Spring , not sure what else I need to do. |
sobychacko
reviewed
Aug 6, 2025
spring-ai-model/src/main/java/org/springframework/ai/model/tool/DefaultToolCallingManager.java
Outdated
Show resolved
Hide resolved
- Replace java.util.* with specific imports - Apply Spring Java format to ensure code style compliance Signed-off-by: huidong.yin <[email protected]>
|
Hi @sobychacko ,Please help review if everything looks good ,thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When method tool or MCP tool with no argument and calling in streaming mode,
errors will occur due to null/empty arguments validation.
This PR adds defensive handling for null/empty tool arguments in streaming mode
by using empty JSON object "{}" as default instead of throwing IllegalArgumentException.
Fixes: #4007